Review Request 128225: Update KAbstractFileItemActionPlugin apidox
Elvis Angelaccio
elvis.angelaccio at kdemail.net
Fri Jun 17 19:16:56 UTC 2016
> On June 17, 2016, 6:58 p.m., David Faure wrote:
> > src/widgets/kabstractfileitemactionplugin.h, line 86
> > <https://git.reviewboard.kde.org/r/128225/diff/2/?file=469121#file469121line86>
> >
> > Is there even a reason to suggest this? Why would someone "want" to install it in another location?
Indeed, I'll drop this line
- Elvis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128225/#review96642
-----------------------------------------------------------
On June 17, 2016, 4:17 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128225/
> -----------------------------------------------------------
>
> (Updated June 17, 2016, 4:17 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Now that Dolphin supports loading of JSON-only KFileItemAction plugins:
>
> * We can stop recommending the .desktop file be installed.
> * We can recommend the plugins be installed in a `kf5/kfileitemaction` subfolder of the plugin path. This is consistent with other (KIO) plugins (kio_dnd, overlayicon...) and clients will be able to speed-up the lookup (by using `KPluginLoader::findPlugins("kf5/kfileitemaction)`.
>
>
> Diffs
> -----
>
> src/widgets/kabstractfileitemactionplugin.h c17e454c6f3f08853386482d5d43313d09ce5243
>
> Diff: https://git.reviewboard.kde.org/r/128225/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160617/4a2fef38/attachment.html>
More information about the Kde-frameworks-devel
mailing list