Review Request 128216: [QueryMatch] Add iconName
Kai Uwe Broulik
kde at privat.broulik.de
Thu Jun 16 22:06:53 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128216/
-----------------------------------------------------------
Review request for KDE Frameworks and Plasma.
Repository: krunner
Description
-------
This adds methods taking an iconName instead of a full-fledged QIcon. It reduces the likelihood of QIcon-related multithreading issues but also significantly speeds up KRunner by doing the icon lookup only in the view and only for icons that we actually display.
Diffs
-----
src/querymatch.h 972ef83
src/querymatch.cpp 474e3ac
Diff: https://git.reviewboard.kde.org/r/128216/diff/
Testing
-------
Usin krunner feels a billion times faster now (I adjusted all runners to use the new api where sensible)
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160616/b7db6d78/attachment.html>
More information about the Kde-frameworks-devel
mailing list