Review Request 128187: Add a program to convert symbolically linked files to qrc aliases

[Kåre Särs]

> On June 16, 2016, 1:14 p.m., David Faure wrote:
> > main.cpp, line 29
> > <https://git.reviewboard.kde.org/r/128187/diff/1/?file=468769#file468769line29>
> >
> >     Recursion? Is there a risk of infinite recursion here?

Yes there is a risk of recursion if the symbolic links also are. Should we add a check or can we assume that the links are sane?


- Kåre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128187/#review96587
-----------------------------------------------------------


On June 16, 2016, 3:26 p.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128187/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 3:26 p.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Kainz, David Faure, and Kevin Funk.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> -------
> 
> On windows git converts symbolic links to text files with links to
> the actual file. This added application modifies the .qrc to use
> aliases for the links.
> 
> This change also adds an option to not install the icons.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 08cd1a0 
>   icons-dark/CMakeLists.txt 5d7e6f8 
>   icons/CMakeLists.txt bd4c048 
>   qrcAlias.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128187/diff/
> 
> 
> Testing
> -------
> 
> Compiled on windows with BINARY_ICONS_RESOURCE and SKIP_INSTALL_ICONS enabled.
> 
> We get the icon .rcc file and the icons where not installed
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160616/ca6aa4c0/attachment.html>