Review Request 128208: [kio] Change to non-deprecated versions of QStyleOption subclasses

David Faure faure at kde.org
Thu Jun 16 13:38:53 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128208/#review96593
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On June 16, 2016, 1:12 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128208/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 1:12 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Starting with Qt 5.7, the old QStyleOption*Vn subclasses (e.g. QStyleOptionViewItemV4) are flagged as deprecated.
> 
> This patch replaces them with the non-deprecated (unversioned) names. It was generated by a "sed" command, so other than the name changes, there are no differences.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kfileplacesview.cpp 5d5fa9d 
>   src/filewidgets/kurlnavigatorbuttonbase.cpp 69ce0ad 
>   src/widgets/kfileitemdelegate.cpp 11254d2 
> 
> Diff: https://git.reviewboard.kde.org/r/128208/diff/
> 
> 
> Testing
> -------
> 
> - Compiles with Qt 5.7 branch and gcc 6.1
> - No remaining output from "grep -r QStyleOption[A-Za-z]*V[2-9]"
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160616/ff385945/attachment.html>


More information about the Kde-frameworks-devel mailing list