Review Request 128187: Add a program to convert symbolically linked files to qrc aliases
Christoph Cullmann
cullmann at kde.org
Thu Jun 16 13:02:21 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128187/#review96586
-----------------------------------------------------------
Given that without this patch, the resource file on Windows is more or less broken, I would like to have this in, seems to be ok and only gives you a penalty if you create the resource as requested per cmake option.
- Christoph Cullmann
On June 16, 2016, 1:01 p.m., Kåre Särs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128187/
> -----------------------------------------------------------
>
> (Updated June 16, 2016, 1:01 p.m.)
>
>
> Review request for KDE Frameworks, Andreas Kainz, David Faure, and Kevin Funk.
>
>
> Repository: breeze-icons
>
>
> Description
> -------
>
> On windows git converts symbolic links to text files with links to
> the actual file. This added application modifies the .qrc to use
> aliases for the links.
>
> This change also adds an option to not install the icons.
>
>
> Diffs
> -----
>
> CMakeLists.txt 08cd1a0
> icons-dark/CMakeLists.txt 5d7e6f8
> icons/CMakeLists.txt bd4c048
> main.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/128187/diff/
>
>
> Testing
> -------
>
> Compiled on windows with BINARY_ICONS_RESOURCE and SKIP_INSTALL_ICONS enabled.
>
> We get the icon .rcc file and the icons where not installed
>
>
> Thanks,
>
> Kåre Särs
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160616/bad26857/attachment.html>
More information about the Kde-frameworks-devel
mailing list