Review Request 128190: Allow KDocTools to always locate at least its own installed stuff
David Faure
faure at kde.org
Wed Jun 15 19:04:19 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128190/#review96533
-----------------------------------------------------------
Ship it!
LGTM
- David Faure
On June 15, 2016, 6:29 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128190/
> -----------------------------------------------------------
>
> (Updated June 15, 2016, 6:29 p.m.)
>
>
> Review request for KDE Frameworks, David Faure, Kevin Funk, Luigi Toscano, and Hannah von Reth.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> Not rely on standardpaths to detect stuff installed by KDocTools on its own (like the customizations).
> This allows to compile documentation on Mac without patches (and I guess same goes for Windows).
>
>
> Diffs
> -----
>
> config-kdoctools.h.cmake 280adbc
> src/xslt.cpp 59b0538
>
> Diff: https://git.reviewboard.kde.org/r/128190/diff/
>
>
> Testing
> -------
>
> make && make install kdoctools
>
> e.g. make in kio now builds documentation without errors about not found stuff on mac.
>
>
> Thanks,
>
> Christoph Cullmann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160615/50e9189f/attachment.html>
More information about the Kde-frameworks-devel
mailing list