Review Request 128193: Deploy the khtml kxmlgui file in a Qt resource file.

[Christoph Cullmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128193/#review96529
-----------------------------------------------------------


Ship it!




Hi, looks ok, but should no the "khtml_browser.rc" be put in the resource, too? Or is that one different?

- Christoph Cullmann


On June 15, 2016, 1:46 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128193/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 1:46 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> KXmlGui has support for this and this is the recommended way of making a framework platform independent.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt a1b90a13abe8e0681087745db1416316bd04f0ac 
>   src/khtml.qrc PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128193/diff/
> 
> 
> Testing
> -------
> 
> Used khtml in KMyMoney on OSX, the rc file was properly located.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160615/68147b27/attachment.html>