Review Request 127906: update qt5options manpage docbook to qt 5.6
David Faure
faure at kde.org
Tue Jun 14 18:19:58 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/#review96492
-----------------------------------------------------------
docs/qt5options/man-qt5options.7.docbook (line 41)
<https://git.reviewboard.kde.org/r/127906/#comment65188>
yes there's an arg (the icon)
docs/qt5options/man-qt5options.7.docbook (line 42)
<https://git.reviewboard.kde.org/r/127906/#comment65187>
yes, there's an arg (the title)
docs/qt5options/man-qt5options.7.docbook (line 47)
<https://git.reviewboard.kde.org/r/127906/#comment65186>
missing '-' in front of "dialogs"?
docs/qt5options/man-qt5options.7.docbook (line 118)
<https://git.reviewboard.kde.org/r/127906/#comment65189>
.. => .
docs/qt5options/man-qt5options.7.docbook (line 199)
<https://git.reviewboard.kde.org/r/127906/#comment65190>
(the difference with -qwindowgeometry is just that -geometry only exists on X11)
docs/qt5options/man-qt5options.7.docbook (line 205)
<https://git.reviewboard.kde.org/r/127906/#comment65191>
missing "-" or "--"?
docs/qt5options/man-qt5options.7.docbook (line 227)
<https://git.reviewboard.kde.org/r/127906/#comment65192>
The users won't know what setApplicationDescription is. I'd remove the second part of the sentence.
docs/qt5options/man-qt5options.7.docbook (line 257)
<https://git.reviewboard.kde.org/r/127906/#comment65193>
The correct spelling is QCommandLineParser (titlecase)
- David Faure
On June 8, 2016, 4:57 a.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127906/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 4:57 a.m.)
>
>
> Review request for Documentation, KDE Frameworks and David Faure.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> All options in this docbook like
>
> display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, title, visual, inputstyle, im, noxim, reverse, stylesheet
>
> are valid for Qt 3.3 QApplication, see
>
> http://doc.qt.io/archives/3.3/qapplication.html#QApplication
>
>
> In Qt 5.6 a QApplication automatically supports a few command line options like
> style, stylesheet, widgetcount, reverse, qmljsdebugger
> see http://doc.qt.io/qt-5/qapplication.html
>
>
> Do we really want to provide a manpage docbook for that?
>
>
> Diffs
> -----
>
> docs/qt5options/man-qt5options.7.docbook d5891eb
>
> Diff: https://git.reviewboard.kde.org/r/127906/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Burkhard Lück
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160614/86c99109/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list