Review Request 128185: Ensure extraction location to be in subfolder
Andreas Cord-Landwehr
cordlandwehr at kde.org
Tue Jun 14 14:01:05 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128185/
-----------------------------------------------------------
(Updated Juni 14, 2016, 2:01 nachm.)
Review request for KDE Frameworks and David Faure.
Changes
-------
added binary test file
Repository: karchive
Description
-------
Behavior change: Switch to Tar's default behavior to avoid extraction
to arbitrary system locations outside of extraction folder. Instead,
extract such files to root location in extraction folder.
Diffs
-----
autotests/karchivetest.h 4b7ecff66c9db54239bb2f82cdf0b96e901880ca
autotests/karchivetest.cpp c8abddfc370a283c56766e5a437f3ba69c575563
src/karchive.cpp 5a7cfc6c92d74c77157dd3fd829eb9b98a90936e
Diff: https://git.reviewboard.kde.org/r/128185/diff/
Testing
-------
See added unit test
File Attachments (updated)
----------------
test file to be located in autotests/tar_relative_path_outside_archive.tar.bz2
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/3a2388ab-b6a6-4c40-a7c0-083d05be2344__tar_relative_path_outside_archive.tar.bz2
Thanks,
Andreas Cord-Landwehr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160614/82d1d241/attachment.html>
More information about the Kde-frameworks-devel
mailing list