Review Request 128170: Allow nsspellcheck to be compiled on mac per default

Kevin Funk kfunk at kde.org
Mon Jun 13 19:11:23 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128170/#review96431
-----------------------------------------------------------


Ship it!




Rest LGTM

- Kevin Funk


On June 13, 2016, 7:43 a.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128170/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 7:43 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> Allow nsspellcheck to be compiled on mac per default
> 
> 
> Diffs
> -----
> 
>   src/plugins/CMakeLists.txt f275f63 
>   src/plugins/nsspellchecker/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128170/diff/
> 
> 
> Testing
> -------
> 
> make && make install work on a mac.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160613/05d7c4b9/attachment.html>


More information about the Kde-frameworks-devel mailing list