Review Request 128159: Suggest to use setupGUI() instead of setXMLFile()
David Faure
faure at kde.org
Mon Jun 13 16:50:23 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128159/#review96423
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On June 13, 2016, 3:49 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128159/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 3:49 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kparts
>
>
> Description
> -------
>
> KXMLGui-based apps should always use `setupGUI()`, which has several advantages over `setXMLFile()` and calls it implicitly.
>
> This patch also adds a code snippet about this.
>
>
> Diffs
> -----
>
> src/mainwindow.h b672a35cba92475200ff15620a21150da19582dd
>
> Diff: https://git.reviewboard.kde.org/r/128159/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160613/b6b73fc6/attachment.html>
More information about the Kde-frameworks-devel
mailing list