Review Request 128161: Make epoxy optional instead of just hacking it out for Windows
Christoph Cullmann
cullmann at kde.org
Mon Jun 13 08:11:27 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128161/
-----------------------------------------------------------
(Updated June 13, 2016, 8:11 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Marco Martin.
Changes
-------
Submitted with commit b7dfcf3e5e3ea8d93686bf5b2c2a20f0d530a4e3 by Christoph Cullmann to branch master.
Repository: kdeclarative
Description
-------
Make epoxy optional instead of just hacking it out for Windows
This allows to compile this framework e.g. on a Mac without epoxy, too, and is IMHO saner than just disabling it for Windows.
Diffs
-----
CMakeLists.txt 42302da
src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 49427aa
src/qmlcontrols/kquickcontrolsaddons/config-kquickcontrolsaddons.h.cmake PRE-CREATION
src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp fc9d0af
Diff: https://git.reviewboard.kde.org/r/128161/diff/
Testing
-------
Tried it on my mac, now compiles. I have no Linux here ATM, perhaps somebody can try if it really still works with epoxy around.
Thanks,
Christoph Cullmann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160613/fa4852ae/attachment.html>
More information about the Kde-frameworks-devel
mailing list