Review Request 128164: Use QIcon for background icon for folder thumbnails
Martin Tobias Holmedahl Sandsmark
martin.sandsmark at kde.org
Sun Jun 12 18:35:23 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128164/
-----------------------------------------------------------
Review request for KDE Frameworks and Plasma.
Bugs: 364253
https://bugs.kde.org/show_bug.cgi?id=364253
Repository: kio-extras
Description
-------
For consistency when using a QPA that doesn't use KIconLoader, use QIcon instead of KIconLoader for getting the background icon for folder thumbnails.
This is visible e. g. in Dolphin when running under a "foreign" session without the plasma-integration QPA: https://bugsfiles.kde.org/attachment.cgi?id=99476
Adding the plasma group to the reviewers, as that was who bugzilla sent to.
Diffs
-----
thumbnail/thumbnail.cpp f63fe25
Diff: https://git.reviewboard.kde.org/r/128164/diff/
Testing
-------
Tried running both without: https://iskrembilen.com/screenshots/withoutplasmaintegration.png
and with plasma-integration: https://iskrembilen.com/screenshots/withplasmaintegration.png
Thanks,
Martin Tobias Holmedahl Sandsmark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160612/b7e5ca45/attachment.html>
More information about the Kde-frameworks-devel
mailing list