Review Request 128148: Fix check to keep QMenu on screen for multiscreen layouts

Eike Hein hein at kde.org
Fri Jun 10 10:54:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128148/#review96343
-----------------------------------------------------------


Ship it!




Ship It!

- Eike Hein


On June 10, 2016, 9:56 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128148/
> -----------------------------------------------------------
> 
> (Updated June 10, 2016, 9:56 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> If x > screenWidth should be if x > screenLeft + screenWidth 
> 
> otherwise all right hand screens get offset
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qmenu.cpp 926df31c0c6db48549d340207d11fd298b52b629 
> 
> Diff: https://git.reviewboard.kde.org/r/128148/diff/
> 
> 
> Testing
> -------
> 
> TaskManager context menus open in the right place.
> 
> (alternately qmenu seems to do this anyway, so I think we can just delete this entire section)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160610/c7a26fd4/attachment.html>


More information about the Kde-frameworks-devel mailing list