Review Request 128085: Fix check that CPU is a valid CPU

David Edmundson david at davidedmundson.co.uk
Thu Jun 9 13:40:34 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128085/
-----------------------------------------------------------

(Updated June 9, 2016, 1:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Solid.


Changes
-------

Submitted with commit f55f25fc7274722486ff83557b3224c0540523f5 by David Edmundson to branch master.


Repository: solid


Description
-------

We have a check that an devices/system/cpu/cpuN entry contains a
processor and not just an empty socket, however it relies on somewhat
outdated /sys files.

cpuN/cpufreq isn't guaranteed to exist as for some systems (my AMD
processor at least).

The docs in the linux kernel imply topology/core_id should always exist,
and should still work as a valid check that we have a populated CPU
socket.


Diffs
-----

  src/solid/devices/backends/udev/udevmanager.cpp 3f3a671798e84e6d577df7c3b9b80150ac4d01fc 

Diff: https://git.reviewboard.kde.org/r/128085/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160609/6b1d0b31/attachment.html>


More information about the Kde-frameworks-devel mailing list