Review Request 128083: Find CPUs by subsystem rather than driver

David Edmundson david at davidedmundson.co.uk
Thu Jun 9 13:40:31 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128083/
-----------------------------------------------------------

(Updated June 9, 2016, 3:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Solid.


Changes
-------

Submitted with commit 0cb9b52b89165de7d92b95d0eb7d46879e9e7825 by David Edmundson to branch master.


Repository: solid


Description
-------

The driver "processor" is part of the ACPI module, which isn't used by
all systems and architectures.

Detecting devices by CPU subsystem seems to work, and whilst
theoretically this change could pick up a non CPU device in the same subsystem they
would be filtered out by the udevmanager which has an extra check
that CPUs are valid and not just empty sockets.


Diffs
-----

  src/solid/devices/backends/udev/udevdevice.cpp 9fb5e092679cd3c6860b2055cf3dedb915addfda 
  src/solid/devices/backends/udev/udevmanager.cpp 3f3a671798e84e6d577df7c3b9b80150ac4d01fc 

Diff: https://git.reviewboard.kde.org/r/128083/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160609/a96e7d84/attachment.html>


More information about the Kde-frameworks-devel mailing list