Review Request 128088: Load KFileItemAction plugins with json metadata

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128088/#review96284
-----------------------------------------------------------


Ship it!




Ship It!

- Emmanuel Pescosta


On June 5, 2016, 8:14 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128088/
> -----------------------------------------------------------
> 
> (Updated June 5, 2016, 8:14 p.m.)
> 
> 
> Review request for Dolphin and KDE Frameworks.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Dolphin currently doesn't support JSON-only KFileItemAction plugins (without a .desktop file).
> This patch adds support for them both in the context menu and in the settings dialog (Services pane).
> 
> Since a plugin can have both a .desktop file and JSON metadata (as is the the case for `kactivitymanagerd_fileitem_linking_plugin`), we need to be sure to not add twice the plugin in the context menu. A QSet is used to prevent this issue.
> 
> Open question: do we want to install these json-only plugins in a specific subdirectory of `$QT_PLUGIN_PATH`? Like `$QT_PLUGIN_PATH/kf5/kio` or something else? This way we could tell Dolphin to only look for plugins within that subfolder (instead of checking every plugin in `$QT_PLUGIN_PATH`).
> 
> 
> Diffs
> -----
> 
>   src/dolphincontextmenu.cpp dfec76144dafd9210aa8b6f45458ded98e27ab53 
>   src/settings/services/servicessettingspage.cpp 4cfa2327c9fa77a6124b4d90040a9784cc8180c5 
> 
> Diff: https://git.reviewboard.kde.org/r/128088/diff/
> 
> 
> Testing
> -------
> 
> * Build Ark master after commit c369264d6c
> * Make sure that the Compress and Extract service menus are shown
> * Make sure that the menus above can be enabled/disabled in the Services pane in the settings
> * Make sure that `kactivitymanagerd_fileitem_linking_plugin` is not shown twice in the context menu
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160607/ee46dd4a/attachment.html>