Review Request 127903: Update kf5options manpage docbook
Luigi Toscano
luigi.toscano at tiscali.it
Tue Jun 7 21:29:22 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127903/#review96267
-----------------------------------------------------------
Generic options for Qt5 (so qt5options) do work for every Qt5 application, including of course the ones that also use Frameworks. This can go in with few changes.
docs/kf5options/man-kf5options.7.docbook (line 10)
<https://git.reviewboard.kde.org/r/127903/#comment65060>
2015?
docs/kf5options/man-kf5options.7.docbook (line 79)
<https://git.reviewboard.kde.org/r/127903/#comment65061>
I would remove the FIXME
docs/kf5options/man-kf5options.7.docbook (line 85)
<https://git.reviewboard.kde.org/r/127903/#comment65062>
How much is left of the original manpage? I think you should add your name and change the comment to state that the Man page was originally written by... (up to kdelibs4).
- Luigi Toscano
On Mag. 26, 2016, 5:01 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127903/
> -----------------------------------------------------------
>
> (Updated Mag. 26, 2016, 5:01 p.m.)
>
>
> Review request for Documentation and KDE Frameworks.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> replace the obsolete content with updates
> Use case for option desktopfile borrowed von Martin Gräßlins commit log
>
> See Also: qt5options - does that really make sense for a kf5 app?
> I really doubt that the qt5options manpage is uptodate
>
>
> Diffs
> -----
>
> docs/kf5options/man-kf5options.7.docbook f79d42c
>
> Diff: https://git.reviewboard.kde.org/r/127903/diff/
>
>
> Testing
> -------
>
> passes checkXML5
>
>
> Thanks,
>
> Burkhard Lück
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160607/bf55b075/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list