Review Request 128114: do not load and debug in the same line
Harald Sitter
sitter at kde.org
Tue Jun 7 09:06:50 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128114/
-----------------------------------------------------------
(Updated June 7, 2016, 9:06 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Andreas Cord-Landwehr and Jeremy Whiting.
Changes
-------
Submitted with commit 81e2895b40684e275aadc944cdbc2f333a20782f by Harald Sitter to branch master.
Repository: knewstuff
Description
-------
if debugging is off the line is no-op and the load never happens, thus
breaking the test since the entry is always empty.
broke as result of review 126017
Diffs
-----
autotests/knewstuffentrytest.cpp a886afc514abfa21b6396a8b2c8c3a88d65b4a5d
Diff: https://git.reviewboard.kde.org/r/128114/diff/
Testing
-------
makes && passes test
Thanks,
Harald Sitter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160607/4d45b83c/attachment.html>
More information about the Kde-frameworks-devel
mailing list