Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

[Anthony Fieroni]

> On Юни 7, 2016, 12:03 преди обяд, Elvis Angelaccio wrote:
> > Are we talking about this bug? https://bugs.kde.org/show_bug.cgi?id=362977
> > 
> > If yes, it's already fixed on Ark master.
> 
> Anthony Fieroni wrote:
>     It's not this, it happens on all backend.
> 
> Elvis Angelaccio wrote:
>     It happens with all CLI-based backends (zip, rar, ...) but it's the same bug. We fixed this on master by reworking how Ark handles external processes.

I still think patch is relevant. finished is needed to delete object cause a leak, and due to async nature, dbus interface makes non block call, it shouldn't be delete obj. Maybe it's better to be
*QObject::connect(job, &KJob::finished, jobView, &Qobject::deleteLater);*


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128113/#review96235
-----------------------------------------------------------


On Юни 7, 2016, 6:28 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128113/
> -----------------------------------------------------------
> 
> (Updated Юни 7, 2016, 6:28 преди обяд)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> -------
> 
> + Fix memory leak in finished
> 
> 
> Diffs
> -----
> 
>   src/kuiserverjobtracker.cpp ebed3a5 
> 
> Diff: https://git.reviewboard.kde.org/r/128113/diff/
> 
> 
> Testing
> -------
> 
> ark --changetofirstpath --add --autofilename zip kjobwidgets
> Crash before, fix with patch
> 
> 
> File Attachments
> ----------------
> 
> backtrace
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/5b87387e-7e7b-4982-b91b-a18f72414509__backtrace
> memcheck
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/ba4b0150-5e01-4cc1-8776-7530d053d6f0__memcheck
> memcheck 7 errorrs
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160607/ae0a3d0c/attachment.html>