Review Request 128114: do not load and debug in the same line

Andreas Cord-Landwehr cordlandwehr at kde.org
Tue Jun 7 08:52:31 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128114/#review96246
-----------------------------------------------------------


Ship it!




Thanks, just wanted to start looking into this issue :)

- Andreas Cord-Landwehr


On Juni 7, 2016, 8:48 vorm., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128114/
> -----------------------------------------------------------
> 
> (Updated Juni 7, 2016, 8:48 vorm.)
> 
> 
> Review request for KDE Frameworks, Andreas Cord-Landwehr and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> if debugging is off the line is no-op and the load never happens, thus
> breaking the test since the entry is always empty.
> 
> broke as result of review 126017
> 
> 
> Diffs
> -----
> 
>   autotests/knewstuffentrytest.cpp a886afc514abfa21b6396a8b2c8c3a88d65b4a5d 
> 
> Diff: https://git.reviewboard.kde.org/r/128114/diff/
> 
> 
> Testing
> -------
> 
> makes && passes test
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160607/2ccaca33/attachment.html>


More information about the Kde-frameworks-devel mailing list