Review Request 128083: Find CPUs by subsystem rather than driver
Martin Gräßlin
mgraesslin at kde.org
Tue Jun 7 07:47:46 UTC 2016
> On June 6, 2016, 11:33 p.m., Rohan Garg wrote:
> > Hi
> > Could we get a shipit on these? I'd really appreciate it if we could have these in Frameworks 5.23
I don't want to disappoint you, but it's too late for 5.23
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128083/#review96236
-----------------------------------------------------------
On June 3, 2016, 2:15 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128083/
> -----------------------------------------------------------
>
> (Updated June 3, 2016, 2:15 p.m.)
>
>
> Review request for KDE Frameworks and Solid.
>
>
> Repository: solid
>
>
> Description
> -------
>
> The driver "processor" is part of the ACPI module, which isn't used by
> all systems and architectures.
>
> Detecting devices by CPU subsystem seems to work, and whilst
> theoretically this change could pick up a non CPU device in the same subsystem they
> would be filtered out by the udevmanager which has an extra check
> that CPUs are valid and not just empty sockets.
>
>
> Diffs
> -----
>
> src/solid/devices/backends/udev/udevdevice.cpp 9fb5e092679cd3c6860b2055cf3dedb915addfda
> src/solid/devices/backends/udev/udevmanager.cpp 3f3a671798e84e6d577df7c3b9b80150ac4d01fc
>
> Diff: https://git.reviewboard.kde.org/r/128083/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160607/71e212be/attachment.html>
More information about the Kde-frameworks-devel
mailing list