Review Request 128085: Fix check that CPU is a valid CPU
Rohan Garg
rohangarg at kubuntu.org
Mon Jun 6 21:33:43 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128085/#review96238
-----------------------------------------------------------
Hi
Could we get a shipit on these? I'd really appreciate it if we could have these in Frameworks 5.23
- Rohan Garg
On June 3, 2016, 5:45 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128085/
> -----------------------------------------------------------
>
> (Updated June 3, 2016, 5:45 p.m.)
>
>
> Review request for KDE Frameworks and Solid.
>
>
> Repository: solid
>
>
> Description
> -------
>
> We have a check that an devices/system/cpu/cpuN entry contains a
> processor and not just an empty socket, however it relies on somewhat
> outdated /sys files.
>
> cpuN/cpufreq isn't guaranteed to exist as for some systems (my AMD
> processor at least).
>
> The docs in the linux kernel imply topology/core_id should always exist,
> and should still work as a valid check that we have a populated CPU
> socket.
>
>
> Diffs
> -----
>
> src/solid/devices/backends/udev/udevmanager.cpp 3f3a671798e84e6d577df7c3b9b80150ac4d01fc
>
> Diff: https://git.reviewboard.kde.org/r/128085/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160606/564c34f8/attachment.html>
More information about the Kde-frameworks-devel
mailing list