Review Request 128039: Fix the window type of the progress widget

[Martin Tobias Holmedahl Sandsmark]

> On June 4, 2016, 7:57 a.m., David Faure wrote:
> > (yet another reason for passing parents to widgets rather than making the layout set the parent automatically later)
> > 
> > Looks good, but I'm missing a bit of info on what the flag should be set. What does this change in practice? Worth a comment in the code or at least the commit log.

I think the reason for it to be set in the code is rather self-explanatory, but I explained with an example of where it "broke" in the commit message.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128039/#review96179
-----------------------------------------------------------


On June 6, 2016, 9:48 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128039/
> -----------------------------------------------------------
> 
> (Updated June 6, 2016, 9:48 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> -------
> 
> The progress widget is a dialog, so we should set the approporiate window flag.
> 
> 
> Diffs
> -----
> 
>   src/kwidgetjobtracker_p.h 2e5e026 
> 
> Diff: https://git.reviewboard.kde.org/r/128039/diff/
> 
> 
> Testing
> -------
> 
> It now has the proper class and is handled appropriately.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160606/0e4ade13/attachment.html>