Review Request 128082: Fix associated applications for mimetypes with uppercase characters in the name

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128082/
-----------------------------------------------------------

(Updated June 3, 2016, 11:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit 4f5cf1be9793b93f483128c22d44630976bbc804 by Wolfgang Bauer to branch master.


Repository: kservice


Description
-------

As the mimetype name is stored in lowercase in the dictionary, we need to convert it to lowercase in the dictionary check in KMimeTypeFactory::serviceOffersOffset() as well.
Otherwise this check always fails if the name contains uppercase characters, and the list of associated applications will always be empty.

Problem reported in openSUSE's bugzilla: http://bugzilla.opensuse.org/show_bug.cgi?id=980046


Diffs
-----

  src/services/kmimetypefactory.cpp 25a2ce1 

Diff: https://git.reviewboard.kde.org/r/128082/diff/


Testing
-------

Open systemsettings5->File Assocations, create a new mimetype (with uppercase characters in the name, e.g. application/LabView), add one or more applications to use for opening that mimetype.

Now the associated applications are remembered and respected (by dolphin e.g.), before the list was always empty.


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160603/01c6776b/attachment-0001.html>