Review Request 128527: FileUndoManager: Undoing symlink creation

[Chinmoy Ranjan Pradhan]

> On July 31, 2016, 9:47 a.m., David Faure wrote:
> > src/widgets/fileundomanager.cpp, line 421
> > <https://git.reviewboard.kde.org/r/128527/diff/2/?file=472624#file472624line421>
> >
> >     Why the isEmpty() check?

For KIO::SimpleJob opStack is empty due to which m_fileCleanupStack is empty. So isEmpty() check is required.


- Chinmoy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128527/#review97941
-----------------------------------------------------------


On July 31, 2016, 9:28 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128527/
> -----------------------------------------------------------
> 
> (Updated July 31, 2016, 9:28 a.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez, David Faure, Eike Hein, and Wolfgang Bauer.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This patch adds the support for undoing creation of new symlinks.
> 
> 
> Diffs
> -----
> 
>   autotests/fileundomanagertest.h c663f92 
>   autotests/fileundomanagertest.cpp 761cc76 
>   src/filewidgets/knewfilemenu.cpp bb6fc04 
>   src/widgets/fileundomanager.cpp ed5edb0 
> 
> Diff: https://git.reviewboard.kde.org/r/128527/diff/
> 
> 
> Testing
> -------
> 
> build
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160731/7e7fff92/attachment.html>