Review Request 128527: FileUndoManager: Undoing symlink creation

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128527/#review97926
-----------------------------------------------------------



Nice! Can you add a testcase in autotests/fileundomanagertest.cpp ?

I would start from FileUndoManagerTest::testCreateDir and adapt it for symlinks. The test should start with
    #ifdef Q_OS_WIN
        QSKIP("Test skipped on Windows for lack of proper symlink support");
    #endif

- David Faure


On July 29, 2016, 4:09 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128527/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 4:09 a.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez, David Faure, Eike Hein, and Wolfgang Bauer.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This patch adds the support for undoing creation of new symlinks.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/knewfilemenu.cpp bb6fc04 
>   src/widgets/fileundomanager.cpp ed5edb0 
>   src/widgets/fileundomanager_p.h 1832b8a 
> 
> Diff: https://git.reviewboard.kde.org/r/128527/diff/
> 
> 
> Testing
> -------
> 
> build
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160730/85ef2ceb/attachment-0001.html>