Review Request 128514: KIconLoader: reduce number of lookups when doing fallbacks

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128514/
-----------------------------------------------------------

(Updated July 30, 2016, 2:08 p.m.)


Review request for KDE Frameworks and Christoph Feck.


Changes
-------

Improve comment, to mention the long term solution for this (this is really the wrong layer for this fallback code...) ; add early-return case to clarify what happens when looking up video-x-generic in the first place.


Repository: kiconthemes


Description
-------

In the first pass, we already checked whether the icon exists in all icon themes.
So in the second pass, there's no point in starting with that again, we can go
ahead and start doing fallbacks right away.

(The comment about the two passes was removed in b84858c, but some of it still
applies.)

Tested with: strace -e file ./kiconengine_unittest testUnknownIconNotCached |& wc -l
Before: 6341
After: 4589


Diffs (updated)
-----

  autotests/kiconloader_benchmark.cpp ded5e0221f8126139a019a8310e8f120672ac3b4 
  src/kiconloader.cpp 951775d77b7ec0e2d8099ee192ca25321dab4544 

Diff: https://git.reviewboard.kde.org/r/128514/diff/


Testing
-------

strace as mentionned above.

All unittests still pass (incl fallback lookups, didn't check how complete those were, though)


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160730/167dcf24/attachment.html>