Review Request 128488: Add a fallback method for query_qmake() when there's no Qt5 installation

David Faure faure at kde.org
Tue Jul 26 11:58:35 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128488/#review97851
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On July 26, 2016, 12:12 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128488/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 12:12 a.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and David Faure.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Addresses its usage on systems where Qt5 isn't installed, it allows for modules using it to decide what they should do.
> 
> 
> Diffs
> -----
> 
>   modules/ECMQueryQmake.cmake 8f4cf17 
> 
> Diff: https://git.reviewboard.kde.org/r/128488/diff/
> 
> 
> Testing
> -------
> 
> Should fix this issue: https://build.kde.org/job/extra-cmake-modules%20master%20latest-qt4/16/PLATFORM=Linux,compiler=gcc/console
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160726/b22e5eaa/attachment.html>


More information about the Kde-frameworks-devel mailing list