Review Request 128413: Add clipboard buttons in the Checksums tab

Elvis Angelaccio elvis.angelaccio at kdemail.net
Sun Jul 24 22:07:19 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128413/
-----------------------------------------------------------

(Updated July 24, 2016, 10:07 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, KDE Usability and David Faure.


Changes
-------

Submitted with commit a67b2ef0a38b7f80803d785c7784785e0e1093c5 by Elvis Angelaccio to branch master.


Repository: kio


Description
-------

As discussed in RR 128283, we can improve the usability of the dialog if we add buttons to interact with the clipboard.

The Paste button is always visible, while the three Copy buttons are hidden until the correspoding checksum is computed.


Diffs
-----

  src/widgets/checksumswidget.ui 543088e 
  src/widgets/kpropertiesdialog.cpp f6d835e 

Diff: https://git.reviewboard.kde.org/r/128413/diff/


Testing
-------

Copy/Paste works as expected.


File Attachments
----------------

Paste button next to the input field.
  https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/0b0d3f06-7294-4ff1-b59d-d13c413c00f5__Spectacle.C31997.png
Example of Copy button
  https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/5f137d47-4592-4f4c-be96-4c2fc3d09978__Spectacle.J32017.png


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160724/7b8da3cd/attachment.html>


More information about the Kde-frameworks-devel mailing list