Review Request 128513: Unittest for content test of kdescendantsproxymodel

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128513/#review97796
-----------------------------------------------------------


Fix it, then Ship it!




I suggest running astyle-kdelibs over the file.

Can be committed then.

BTW QEXPECT_FAIL is more correct than QSKIP for known failures, when possible.


autotests/kdescendantsproxymodeltest.cpp (line 28)
<https://git.reviewboard.kde.org/r/128513/#comment65897>

    { on separate line



autotests/kdescendantsproxymodeltest.cpp (line 30)
<https://git.reviewboard.kde.org/r/128513/#comment65898>

    space after "for"



autotests/kdescendantsproxymodeltest.cpp (line 33)
<https://git.reviewboard.kde.org/r/128513/#comment65899>

    space after for, kill trailing space



autotests/kdescendantsproxymodeltest.cpp (line 34)
<https://git.reviewboard.kde.org/r/128513/#comment65903>

    { on same line as for



autotests/kdescendantsproxymodeltest.cpp (line 43)
<https://git.reviewboard.kde.org/r/128513/#comment65896>

    align to column 0



autotests/kdescendantsproxymodeltest.cpp (line 53)
<https://git.reviewboard.kde.org/r/128513/#comment65900>

    swap args, expected value is second



autotests/kdescendantsproxymodeltest.cpp (line 64)
<https://git.reviewboard.kde.org/r/128513/#comment65902>

    two spaces before =



autotests/kdescendantsproxymodeltest.cpp (line 66)
<https://git.reviewboard.kde.org/r/128513/#comment65901>

    space after comma


- David Faure


On July 24, 2016, 11:56 a.m., Sune Vuorela wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128513/
> -----------------------------------------------------------
> 
> (Updated July 24, 2016, 11:56 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure, Friedrich W. H. Kossebau, and Stephen Kelly.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> A skipped unit test for https://git.reviewboard.kde.org/r/128398/
> 
> Note. the fix in that review does not seem to fix this test for me.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt dc8d779 
>   autotests/kdescendantsproxymodeltest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128513/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sune Vuorela
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160724/eb8805cd/attachment.html>