Review Request 128477: Do not delete system relevant files in tests (if we might succeed)

[Tobias Berner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128477/
-----------------------------------------------------------

(Updated July 23, 2016, 7:23 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit ea8a1c25dea0accea7a77f529647f2ac45e5d722 by Tobias C. Berner to branch master.


Repository: kio


Description
-------

Some tests for kio try to move system relevant files&paths with the blind assumption that 
the permissions to touch these files is not present. 
The files are 
- /etc/passwd
- /etc/cups
- /etc
- /boot
[sic!].


Check that the process does not actually have the rights to touch system
relevant files when running the
- TestTrash::trashDirectoryOwnedByRoot
- TestTrash::trashFileOwnedByRoot
- JobTest::moveFileNoPermissions
- JobTest::moveDirectoryNoPermissions
tests -- and bail out of them if so.


This patch probably still needs some more work [maybe I also missed another naughty test?],
and I welcome every kind of input on it (apart from the straw man *don't run tests as root* ;) ).


Diffs
-----

  autotests/jobtest.cpp 579c507 
  src/ioslaves/trash/tests/testtrash.cpp c71df13 

Diff: https://git.reviewboard.kde.org/r/128477/diff/


Testing
-------

Without patch:
- enjoying two hours of restoring a system without /etc & /boot

With patch:
- grep 'must not' Testing/Temporary/LastTest.log.tmp
     SKIP   : TestTrash::trashFileOwnedByRoot() Test must not be run by root.
     SKIP   : TestTrash::trashDirectoryOwnedByRoot() Test must not be run by root.
     SKIP   : JobTest::moveFileNoPermissions() Test must not be run by root.
     SKIP   : JobTest::moveDirectoryNoPermissions() Test must not be run by root.


Thanks,

Tobias Berner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160723/07df41b3/attachment.html>