Review Request 128428: KRecursiveFilterProxyModel: fix QSFPM corruption due to filtering out rowsRemoved signal

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128428/
-----------------------------------------------------------

(Updated July 22, 2016, 10:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Laurent Montel and Stephen Kelly.


Changes
-------

Submitted with commit e2a688651cc5fb3cca682c4153866609713e76a9 by David Faure to branch master.


Bugs: 349789
    https://bugs.kde.org/show_bug.cgi?id=349789


Repository: kitemmodels


Description
-------

If the row being removed from the source model isn't shown by KRFPM,
it's correct that we don't need to emit any signals, however we still
need to tell our base class QSFPM so that it updates the mappings
of the visible siblings below that removed row.

Testcase: deleting the Last Search folder in kmail
(full integration test for this testcase will be added to mailcommon).


Diffs
-----

  autotests/krecursivefilterproxymodeltest.cpp 85dbdfa293563671f885df8d09bac30db64ec1cc 
  src/krecursivefilterproxymodel.cpp 10632ec00f2942ba559f710fc83f60dfd84af790 

Diff: https://git.reviewboard.kde.org/r/128428/diff/


Testing
-------

* Removing the Last Search folder in kmail
* This unittest showed [3* ] instead of [2* 3*] before the fix
* As mentionned, I wrote an automated test in mailcommon that creates+deletes the search folder, after ensuring it's above other resources in the ETM toplevel collection order.
I spent about 15-20 hours debugging this before finally being able to create a failing test (then it was easy).


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160722/49aa8762/attachment-0001.html>