Review Request 128413: Add clipboard buttons in the Checksums tab

Elvis Angelaccio elvis.angelaccio at kdemail.net
Fri Jul 22 21:21:07 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128413/
-----------------------------------------------------------

(Updated July 22, 2016, 9:21 p.m.)


Review request for KDE Frameworks, KDE Usability and David Faure.


Changes
-------

Patch rebased.

@dfaure: is this ok code-wise?


Repository: kio


Description
-------

As discussed in RR 128283, we can improve the usability of the dialog if we add buttons to interact with the clipboard.

The Paste button is always visible, while the three Copy buttons are hidden until the correspoding checksum is computed.


Diffs (updated)
-----

  src/widgets/checksumswidget.ui 543088e 
  src/widgets/kpropertiesdialog.cpp f6d835e 

Diff: https://git.reviewboard.kde.org/r/128413/diff/


Testing
-------

Copy/Paste works as expected.


File Attachments (updated)
----------------

Paste button next to the input field.
  https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/0b0d3f06-7294-4ff1-b59d-d13c413c00f5__Spectacle.C31997.png
Example of Copy button
  https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/5f137d47-4592-4f4c-be96-4c2fc3d09978__Spectacle.J32017.png


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160722/99e0c219/attachment.html>


More information about the Kde-frameworks-devel mailing list