Review Request 128490: Checksums tab: replace groupbox with vertical separator
Elvis Angelaccio
elvis.angelaccio at kdemail.net
Fri Jul 22 09:07:01 UTC 2016
> On July 21, 2016, 10:51 p.m., Martin Klapetek wrote:
> > Just a tiny note - that separator is horizontal, not vertical ;)
Oh, of course ;)
- Elvis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128490/#review97737
-----------------------------------------------------------
On July 20, 2016, 1:01 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128490/
> -----------------------------------------------------------
>
> (Updated July 20, 2016, 1:01 p.m.)
>
>
> Review request for KDE Frameworks and KDE Usability.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Follow up of RR [128283](https://git.reviewboard.kde.org/r/128283/) and in particular [128466](https://git.reviewboard.kde.org/r/128466/). This patch replaces the "Share" groupbox with a vertical separator.
>
> Don't forget that there is also RR [128413](https://git.reviewboard.kde.org/r/128413/) pending ;)
>
>
> Diffs
> -----
>
> src/widgets/checksumswidget.ui 03c64db
> src/widgets/kpropertiesdialog.cpp 808765c
>
> Diff: https://git.reviewboard.kde.org/r/128490/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Before
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/e39d8b29-5837-4236-833b-26ecafe18bfb__checksums-tab.png
> After
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/d1ec9cee-03e5-4b26-9852-876e48aa5143__Spectacle.T11454.png
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160722/cd6574fa/attachment.html>
More information about the Kde-frameworks-devel
mailing list