Review Request 128451: KNewFileMenu: fix creating symlinks with a relative target.

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128451/#review97731
-----------------------------------------------------------


Ship it!




Ship It!

- Jeremy Whiting


On July 21, 2016, 3:30 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128451/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 3:30 p.m.)
> 
> 
> Review request for KDE Frameworks, Chinmoy Ranjan Pradhan and Jeremy Whiting.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> KNameAndUrlInputDialog::url() makes URLs absolute (which is useful in
> general, for e.g. passing to KIO), so I added urlText() to retrieve
> the text as is.
> 
> This removes all the code about showing an error on remote URLs; we just
> create symlinks to the requested target, whether it looks like "../foo" or
> "a:/b" which could be a relative path too (although an unusual one).
> 
> Bug misreported as a comment in bug 352927.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/knameandurlinputdialog.h c32745d02a1a7361ac35a836cf57d7b9952cc49f 
>   src/filewidgets/knameandurlinputdialog.cpp b7a6645874673e998e05ee73a2daef746ce39dd6 
>   src/filewidgets/knewfilemenu.cpp 2e613b19a98587c9a62c9cccf0f8695730798e89 
> 
> Diff: https://git.reviewboard.kde.org/r/128451/diff/
> 
> 
> Testing
> -------
> 
> Created a symlink to "../anotherdir" in konqueror/dolphinpart using "Create New" / "Basic link to file or directory...", the target now stays relative.
> 
> I looked up who wrote that symlink creation code in order to add him as a reviewer .... turns out the author of commit 8684162 in kde-baseapps is .... me.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160721/b7ca3873/attachment-0001.html>