Review Request 128492: [kio] Minor typo in file ioslave

Chinmoy Ranjan Pradhan chinmoyrp65 at gmail.com
Thu Jul 21 20:14:06 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128492/
-----------------------------------------------------------

(Updated July 21, 2016, 8:14 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit 1f30604a4cd1a96d8b733cdae53c5adbe38fda59 by Albert Astals Cid on behalf of Chinmoy Ranjan Pradhan to branch master.


Repository: kio


Description
-------

This fixes a typo in file ioslave source.
Before initiating a put job the existence of the original file is checked. But the path of '.part' file is passed as argument instead of path of the original file. As a result a put job is initiated even though the file exist.

The Error Message:
When user tries to create a new file with an existing name, the following error message shows up. Instead of saying that the file with the given name exist, the error says can't rename partial file.


Diffs
-----

  src/ioslaves/file/file.cpp 9a8ca32 

Diff: https://git.reviewboard.kde.org/r/128492/diff/


Testing
-------


File Attachments
----------------

the error message
  https://git.reviewboard.kde.org/media/uploaded/files/2016/07/21/70053ddf-d72d-4ffe-936a-c38068de5d0d__erroemessage.png


Thanks,

Chinmoy Ranjan Pradhan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160721/9f233365/attachment.html>


More information about the Kde-frameworks-devel mailing list