Review Request 128476: Add scrollbars to kcm started without systemsettings5

Olivier Churlaud olivier at churlaud.com
Wed Jul 20 14:23:26 UTC 2016



> On July 20, 2016, 4:20 p.m., David Edmundson wrote:
> > This affects the initial size of the showed screen, that needs fixing.
> > Previously it showed the entire KCM, now it won't.

yes it's written in the description, I would need help for this actually. The good point is that now, I can validate my changes.


- Olivier


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128476/#review97667
-----------------------------------------------------------


On July 20, 2016, 4:20 p.m., Olivier Churlaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128476/
> -----------------------------------------------------------
> 
> (Updated July 20, 2016, 4:20 p.m.)
> 
> 
> Review request for KDE Frameworks, Kai Uwe Broulik and Christoph Feck.
> 
> 
> Bugs: 360260
>     https://bugs.kde.org/show_bug.cgi?id=360260
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> This adds scrollbars when needed.
> 
> I cannot manage to get the size of the window right: help on this bit would be appreciated.
> 
> 
> Diffs
> -----
> 
>   src/kcmultidialog.cpp 22592c4 
> 
> Diff: https://git.reviewboard.kde.org/r/128476/diff/
> 
> 
> Testing
> -------
> 
> Compiles, behave as expected (expect for the size)
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160720/8fa43c29/attachment.html>


More information about the Kde-frameworks-devel mailing list