Review Request 120904: [KCharSelect] Handle characters outside BMP

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120904/
-----------------------------------------------------------

(Updated July 20, 2016, 1:48 p.m.)


Review request for KDE Frameworks and Daniel Laidig.


Changes
-------

- protect against setting code points outside of Unicode range
- emit code point changes even when not allowing characters outside BMP


Bugs: 142625
    https://bugs.kde.org/show_bug.cgi?id=142625


Repository: kwidgetsaddons


Description
-------

Changed QChar to uint everywhere in KCharSelect to be able to handle non-BMP characters.

Old API is still working, unless the user does setAllPlanesEnabled(true), then it is expected that she does use the new API.

This is the first step to fix bug 142625, and should be committed as early as possible (for 5.25?), so that application developers have time to adopt the new API.


Diffs (updated)
-----

  src/kcharselect.h 05ec77c 
  src/kcharselect.cpp 5649200 
  src/kcharselect_p.h 07b4ead 
  src/kcharselectdata.cpp aea958c 
  src/kcharselectdata_p.h 2f9332d 

Diff: https://git.reviewboard.kde.org/r/120904/diff/


Testing
-------

When using utils/kcharselect without patch from https://git.reviewboard.kde.org/r/128453/ it seems to work as previously.

When applying above patch to utils/kcharselect:

* kcharselect-data still only has 16 bit data, so no blocks outside the BMP can be browsed. The code to create and parse the database still needs to be updated.
* you can search for 0x12345 unicode or 0x23456 unicode, and see some naming difference
* you can copy the resulting non-BMP character


Thanks,

Christoph Feck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160720/24bbaed5/attachment-0001.html>