Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128427/#review97600
-----------------------------------------------------------



This seems to break when used with Qt4.
https://build.kde.org/job/extra-cmake-modules%20master%20latest-qt4/16/PLATFORM=Linux,compiler=gcc/console

Failed call: qmake-qt5 -query "QT_INSTALL_PREFIX"

(it is likely that this error was already happening with the other piece of code querying qmake the same way, this build has been yellow for some time)

- David Faure


On July 18, 2016, 1:08 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128427/
> -----------------------------------------------------------
> 
> (Updated July 18, 2016, 1:08 p.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Antonio Rojas.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> In `KDEInstallDirs` we have some code to make sure that qmake is asked when the project shares the prefix with the installed Qt, to make sure that if something was changed in the distribution it would reflect on the projects.
> Make sure PRI files are installed using the same reasoning.
> 
> 
> Diffs
> -----
> 
>   modules/ECMGeneratePriFile.cmake af4b877 
> 
> Diff: https://git.reviewboard.kde.org/r/128427/diff/
> 
> 
> Testing
> -------
> 
> The issue was reported by `arojas`, I haven't been able to reproduce myself.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160719/988bf076/attachment.html>