Review Request 128466: Rename Checksums tab to Integrity
Sebastian Kügler
sebas at kde.org
Mon Jul 18 12:31:42 UTC 2016
> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote:
> > Please don't ship it, yet.
> >
> >
> > I find the UI illogical. There's a groupbox grouping the checksum buttons, but then you can input the checksum above, so essentially, the groupbox is unnecessary and confusing.
> >
> > Perhaps the whole thing could be simplified by naming the tab "Checksums" and removing the groupbox altogether, as it's not providing any semantic value.
> >
> > A usability reviewer should have a look.
>
> Kai Uwe Broulik wrote:
> This dialog has been created in Review 128283 and Usability has been involved from the beginning...
>
> Sebastian Kügler wrote:
> It has changed in a significant way, though, making it illogical.
>
> (Not that I understand the "Share" title in the original review, but that's another matter.)
>
> This needs more work.
>
> Elvis Angelaccio wrote:
> > Perhaps the whole thing could be simplified by naming the tab "Checksums" and removing the groupbox altogether, as it's not providing any semantic value.
>
> Preview here: https://share.kde.org/index.php/s/RUs9gAhIQqpFIqF
This looks logical to me, and it's simpler: Very good!
(Take that as "sebas withdraws his objection" :))
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128466/#review97521
-----------------------------------------------------------
On July 16, 2016, 12:35 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128466/
> -----------------------------------------------------------
>
> (Updated July 16, 2016, 12:35 p.m.)
>
>
> Review request for KDE Frameworks, KDE Usability and Dominik Haumann.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Dominik suggested to rename the `Checksums` tab to `Integrity`, so that we can "free" the Checksums string and use it as the title of the groupbox below (in place of the current `Share` string, which can be confusing).
>
> Preview in the attached screenshot.
>
>
> Diffs
> -----
>
> src/widgets/checksumswidget.ui 03c64db
> src/widgets/kpropertiesdialog.cpp 808765c
>
> Diff: https://git.reviewboard.kde.org/r/128466/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Before
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/16/6771ed06-c803-4d18-abe3-91e4f97c8c76__checksums-tab.png
> After
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/16/b2cd12c8-6bbf-4123-9e8e-59cb0c29cbdb__Spectacle.TJ7614.png
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160718/dac39800/attachment.html>
More information about the Kde-frameworks-devel
mailing list