Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

David Faure faure at kde.org
Sat Jul 16 10:14:23 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128427/#review97471
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On July 12, 2016, 12:21 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128427/
> -----------------------------------------------------------
> 
> (Updated July 12, 2016, 12:21 a.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Antonio Rojas.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> In `KDEInstallDirs` we have some code to make sure that qmake is asked when the project shares the prefix with the installed Qt, to make sure that if something was changed in the distribution it would reflect on the projects.
> Make sure PRI files are installed using the same reasoning.
> 
> 
> Diffs
> -----
> 
>   modules/ECMGeneratePriFile.cmake af4b877 
> 
> Diff: https://git.reviewboard.kde.org/r/128427/diff/
> 
> 
> Testing
> -------
> 
> The issue was reported by `arojas`, I haven't been able to reproduce myself.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160716/0619bfa0/attachment.html>


More information about the Kde-frameworks-devel mailing list