Review Request 128458: KProtocolInfo: refill cache to find newly installed protocols

Christoph Cullmann cullmann at kde.org
Fri Jul 15 13:24:05 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128458/#review97446
-----------------------------------------------------------



Given we refill the cache now if some protocol is not found, this for sure fixes my regression.
If that has a very bad performance impact: I doubt it, beside your really have tight loops always using not known protocols.

- Christoph Cullmann


On July 15, 2016, 8:35 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128458/
> -----------------------------------------------------------
> 
> (Updated July 15, 2016, 8:35 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> KProtocolInfo: refill cache to find newly installed protocols
> 
> 
> Diffs
> -----
> 
>   src/core/kprotocolinfofactory.cpp 1329b6b98bb42be27f06aaacf29d51157290bbb4 
> 
> Diff: https://git.reviewboard.kde.org/r/128458/diff/
> 
> 
> Testing
> -------
> 
> $ git clone git at github.com:shortstheory/staging-kioslave
> $ compile and install
> $ kioclient5 list stash:/
> 
> Now works, using a klauncher with this fix.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160715/7d0ac86b/attachment.html>


More information about the Kde-frameworks-devel mailing list