Review Request 125830: Read protocol info from plugin metadata

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125830/#review97430
-----------------------------------------------------------



The problem with this change is that klauncher no longer recognizes freshly installed kioslaves.

Testcase:
$ git clone git at github.com:shortstheory/staging-kioslave
$ compile and install
$ kioclient5 list stash:/
KIO::ProtoQueue::createSlave: couldn't create slave: "Unable to create io-slave:\nklauncher said: Unknown protocol 'stash'.\n"

Either we need to compare directory mtimes, or we need to refill the cache in case we hit an unknown protocol, hopefully this doesn't happen in tight loops.
I implemented the latter. https://git.reviewboard.kde.org/r/128458/

- David Faure


On Oct. 29, 2015, 10:58 a.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125830/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 10:58 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Extends the protocol factory and co. to allow reading of protocol data from embedded json.
> Allows to deploy io slaves without anything else than the io slave itself in librarypath kf5/kio.
> 
> I changed to factory to ALWAYS fill its cache for any request, as now the determination which protocols are around is more expensive than just some directory traversal.
> 
> If this preview is ok, I will do that for all other shipped slaves and update this request.
> 
> 
> Diffs
> -----
> 
>   src/core/kprotocolinfo.cpp 8a02f7a 
>   src/core/kprotocolinfo_p.h c3dea6b 
>   src/core/kprotocolinfofactory.cpp 29ba8f4 
>   src/core/kprotocolinfofactory_p.h aa79fc5 
>   src/ioslaves/http/http.cpp 1727d41 
>   src/ioslaves/http/http.json PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125830/diff/
> 
> 
> Testing
> -------
> 
> http slave still seems to be found and work.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160715/e11a695a/attachment.html>