Review Request 128413: Add clipboard buttons in the Checksums tab

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128413/#review97287
-----------------------------------------------------------


Ship it!




Looks good to me.

I suggest making a the calculated checksum a KSqueezedTextLabel [1], this way the checksum does not break the layout (in one of the animated gifs, the width of the dialog changes).
[1] https://api.kde.org/frameworks/kwidgetsaddons/html/classKSqueezedTextLabel.html

- Dominik Haumann


On July 9, 2016, 7:55 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128413/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 7:55 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> As discussed in RR 128283, we can improve the usability of the dialog if we add buttons to interact with the clipboard.
> 
> The Paste button is always visible, while the three Copy buttons are hidden until the correspoding checksum is computed.
> 
> 
> Diffs
> -----
> 
>   src/widgets/checksumswidget.ui 03c64db 
>   src/widgets/kpropertiesdialog.cpp 808765c 
> 
> Diff: https://git.reviewboard.kde.org/r/128413/diff/
> 
> 
> Testing
> -------
> 
> Copy/Paste works as expected.
> 
> 
> File Attachments
> ----------------
> 
> Paste button next to the input field.
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/906d90f6-7727-4163-9992-c688667073ec__Spectacle.J11500.png
> Example of Copy button
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/10c18534-0e72-4c8c-98ae-144a909438c9__Spectacle.J11519.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160711/438d11ba/attachment.html>