Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor
Ragnar Thomsen
rthomsen6 at gmail.com
Sat Jul 9 11:47:13 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128406/
-----------------------------------------------------------
(Updated July 9, 2016, 1:47 p.m.)
Review request for KDE Frameworks, David Edmundson and Elvis Angelaccio.
Changes
-------
Add a unittest which provokes the crash.
Repository: kwidgetsaddons
Description
-------
We are using KCollapsibleGroupBox in Ark and stumbled upon a segfault in an autotest involving this widget (see backtrace [here](https://paste.kde.org/pwcohd64z)). It looks like QTimeLine::stop() gets called after KCollapsibleGroupBox is deleted. This causes QTimeLine::stateChanged to get emitted which then calls KCollapsibleGroupBox::updateChildrenVisibility() that causes the crash.
To see the crash, clone the newAddDialog branch of Ark and run the autotests.
This diff calls QTimeLine::stop() in the KCollapsibleGroupBox dtor if it is running, before deleting the d pointer.
Diffs (updated)
-----
autotests/CMakeLists.txt 4be2eaf
autotests/kcollapsiblegroupbox_test.h PRE-CREATION
autotests/kcollapsiblegroupbox_test.cpp PRE-CREATION
src/kcollapsiblegroupbox.cpp 0c3f866
Diff: https://git.reviewboard.kde.org/r/128406/diff/
Testing
-------
The autotests in newAddDialog branch of Ark pass with this diff.
Thanks,
Ragnar Thomsen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160709/ba5b27a9/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list