Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

[Olivier Churlaud]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128397/#review97221
-----------------------------------------------------------



Compiled and tested on archlinux: it fixed https://sourceforge.net/p/texstudio/bugs/1837/ which was related to bug 365130.

Not completely though, as the icon of the app is not shown in the taskbar (but it might be another bug). Looking forward for the release.

- Olivier Churlaud


On July 8, 2016, 2:24 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128397/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 2:24 p.m.)
> 
> 
> Review request for KDE Frameworks and Olivier Goffart.
> 
> 
> Bugs: 365130
>     https://bugs.kde.org/show_bug.cgi?id=365130
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> QIcon::hasThemeIcon(name) checks if QIcon::name() == name, so icon engine must return empty string when icon doesn't exist.
> Also implement IsNullHook for Qt 5.7. Comes with autotest.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 0c7de50 
>   autotests/kiconengine_unittest.cpp PRE-CREATION 
>   src/kiconengine.h 21a63f5 
>   src/kiconengine.cpp 3ccc7d1 
> 
> Diff: https://git.reviewboard.kde.org/r/128397/diff/
> 
> 
> Testing
> -------
> 
> Issue was reported in https://bugreports.qt.io/browse/QTBUG-54595
> Also similar issue https://bugs.kde.org/show_bug.cgi?id=365031 (there is a check for hasThemeIcon before using the icon, but it returns true which results in invalid icon name -> no icon).
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160708/446a65b9/attachment.html>