Review Request 128369: Handle multiple gzip streams in a single file

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128369/
-----------------------------------------------------------

(Updated July 5, 2016, 11:25 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Sune Vuorela.


Changes
-------

Submitted with commit 853496897f5216909337ed8711e1b8391ae1b6a3 by Martin T. H. Sandsmark to branch master.


Repository: karchive


Description
-------

Handle multiple gzip streams
    
    If kgzipfilter notices that zlib didn't read all the data, it tries to
    re-init the stream and read the rest of the buffer. This is tested by
    the unit test from Sune. The case where there's more than two streams
    available in the current buffer is tested in a unit test added
    separately.
    
    If the split between the streams falls right between two buffers, we
    need KCompressionDevice to notice that there's data left and try to
    continue decompressing. This is easy to test by setting BUFFER_SIZE to
    the size of the first stream in the unit test data (28 bytes).


Diffs
-----

  autotests/kfiltertest.cpp 4408dbe 
  src/kcompressiondevice.cpp d6ecebd 
  src/kgzipfilter.cpp 27a6d99 

Diff: https://git.reviewboard.kde.org/r/128369/diff/


Testing
-------

The unit test now passes.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160705/932b6340/attachment.html>