Review Request 128369: Handle multiple gzip streams in a single file

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128369/#review97103
-----------------------------------------------------------



Nice !


src/kgzipfilter.cpp (line 331)
<https://git.reviewboard.kde.org/r/128369/#comment65592>

    This is where you could add something like
         if (avail_in < 10) {
             return Ok; // come back when we have more
         }
         if (readHeader()) { ... }
    no?


- David Faure


On July 4, 2016, 9:28 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128369/
> -----------------------------------------------------------
> 
> (Updated July 4, 2016, 9:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Sune Vuorela.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> This assumes that the split between the streams is in the current buffer, though.
> 
> 
> Diffs
> -----
> 
>   autotests/kfiltertest.cpp 4408dbe 
>   src/kgzipfilter.cpp 27a6d99 
> 
> Diff: https://git.reviewboard.kde.org/r/128369/diff/
> 
> 
> Testing
> -------
> 
> The unit test now passes.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160704/4e574aae/attachment.html>