Review Request 128316: Make use of QQuickItem::setSize instead of width and height indpedently.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128316/
-----------------------------------------------------------

(Updated July 4, 2016, 10:06 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit fb3e8d5fc5841cd176e88827016cefb3eac30ef0 by David Edmundson to branch master.


Repository: plasma-framework


Description
-------

Even though QQuickItem only has a width and height accessor there is a
usable public setSize method.

This gets rid of a lot of potential pointless re-evaluation as internal geometry
is updated before widthChanged is emitted.


Diffs
-----

  src/plasmaquick/appletquickitem.cpp a9d044b1b50eace5d20441700eba3733c14b1ffd 
  src/plasmaquick/configview.cpp 5c2920bdc97643a353d47d6698a56f5d898b82e7 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp adacbe19c3f306cf442850d45fed2933e48e6b4b 

Diff: https://git.reviewboard.kde.org/r/128316/diff/


Testing
-------

Restarted Plasma, everything seems normal


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160704/54fe26db/attachment.html>